test: Make tests not squelch color when being run by bazel. #4006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basvandijk
approved these changes
Feb 18, 2025
…What this literally does is sets the CLICOLOR_FORCE environment variable to true. This is a convention that different programs follow. In particular, the colored Rust library uses it (and canbench uses colored).
daniel-wong-dfinity-org
force-pushed
the
bazel-no-squelch-color-daniel-wong
branch
from
87e566d to
67cd361
Compare
…oloring. (This is why tests should not look long exact strings in output that is intended for human consumption, and instead should just look for key words.)
Sawchord
approved these changes
Feb 19, 2025
randombit
approved these changes
Feb 19, 2025
daniel-wong-dfinity-org
deleted the
bazel-no-squelch-color-daniel-wong
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this literally does is sets the
CLICOLOR_FORCEenvironment variable totrue. This causes terminal output to be colored, if the test follows that convention. In particular, the Rustcoloredlibrary uses that convention. In particular, canbench usescolored. This makes the output of canbench easier for humans to consume (and we should really care about humans, such as ourselves).